ESLint Plugin: Continue considering unused variables after encountering exception #21354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Bug
aduth
requested review from
ajitbohra,
ellatrix,
gziolo,
jorgefilipecosta,
mkaz,
nerrad,
ntwb,
Soean,
talldan and
youknowriad
as code owners
aduth
added
the
Good First Review
|
Size Change: -7 B (0%) Total Size: 903 kB
ℹ️ View Unchanged
|
aduth
commented
Apr 2, 2020
gziolo
approved these changes
Apr 10, 2020
aduth
force-pushed
the
fix/no-unused-vars-before-return-skips-all
branch
from
0fb7623
to
fd56b48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: #16737
This pull request seeks to fix an issue with the custom ESLint rule
@wordpress/no-unused-vars-before-return, where an exception identified by theexcludePatternwill cause all other candidate issues to be skipped, therefore allowing errors to be inadvertently introduced. Notably, this would occur in Gutenberg when React hooks are present. And it was more pronounced because React hooks should always occur at the very beginning of a component's render implementation.Implementation notes:
At the most basic, the issue is that a
continue;should have been used to skip an exception when iterating candidate issues, but areturn;was used instead, thus aborting checks of all other candidates of the loop.Fixes to current issues are included in these changes.
Testing Instructions:
Ensure unit tests pass:
Ensure lint passes: