New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide editable placeholders on focus #2161

Merged
merged 1 commit into from Aug 2, 2017

Conversation

Projects
None yet
2 participants
@iseulde
Member

iseulde commented Aug 2, 2017

While it's unlike the behaviour of normal input fields, it's been suggested that we should hide placeholders on focus. This will prevent them from popping up while writing.

@iseulde iseulde requested a review from mtias Aug 2, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 2, 2017

Codecov Report

Merging #2161 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2161   +/-   ##
=======================================
  Coverage   22.26%   22.26%           
=======================================
  Files         136      136           
  Lines        4272     4272           
  Branches      721      721           
=======================================
  Hits          951      951           
  Misses       2804     2804           
  Partials      517      517
Impacted Files Coverage Δ
blocks/editable/index.js 0.47% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46cd098...bc7927d. Read the comment docs.

codecov bot commented Aug 2, 2017

Codecov Report

Merging #2161 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2161   +/-   ##
=======================================
  Coverage   22.26%   22.26%           
=======================================
  Files         136      136           
  Lines        4272     4272           
  Branches      721      721           
=======================================
  Hits          951      951           
  Misses       2804     2804           
  Partials      517      517
Impacted Files Coverage Δ
blocks/editable/index.js 0.47% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46cd098...bc7927d. Read the comment docs.

@mtias

mtias approved these changes Aug 2, 2017

This feels much better to me.

@iseulde iseulde merged commit 240f8a8 into master Aug 2, 2017

3 checks passed

codecov/project 22.26% remains the same compared to 46cd098
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@iseulde iseulde deleted the try/hide-placeholder-focus branch Aug 2, 2017

@karmatosed karmatosed referenced this pull request May 11, 2018

Closed

fix: Restore placeholders for all RichText Blocks #6647

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment