Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Audio Block #2299
This branch adds the basics of the audio block. Currently you can select/upload an audio file from the Media Library, or use an external url. As mentioned on the ticket, the audio widget supports additional parameters like adding additional playback types, and looping - which we might consider in future iterations.
Also, perhaps there could potentially be some simple validation on the url field - but taking a page from the video block and trying to simplify things for now.
Looks good. The extra class works, on the front end but not the back end, don't think that is related to this PR though. One of the tests is not cleaning up correctly and failing. We might need to coordinate with #2309, as the problem lies across both of them. Going to push the fixtures to this branch.
referenced this pull request
Aug 9, 2017
@@ Coverage Diff @@ ## master #2299 +/- ## ========================================== + Coverage 25.82% 25.84% +0.02% ========================================== Files 156 157 +1 Lines 4829 4840 +11 Branches 815 817 +2 ========================================== + Hits 1247 1251 +4 - Misses 3024 3029 +5 - Partials 558 560 +2
Tested it out and it worked well for me on inserting from Media Library, but an issue when trying to type in a URL. It would insert immediately on first letter type and fail since
Also, you will probably want to add an Upload button next to the Insert, similar to how Image & Gallery are now doing but that probably can come with a version 1.1