Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks: Adding a simple video block #2309

Merged
merged 3 commits into from Aug 10, 2017

Conversation

@youknowriad
Copy link
Contributor

commented Aug 9, 2017

closes #2149

This PR adds a simple video block. No advanced options for now.

@youknowriad youknowriad added the Blocks label Aug 9, 2017

@youknowriad youknowriad self-assigned this Aug 9, 2017

@youknowriad youknowriad requested review from karmatosed and jasmussen Aug 9, 2017

@jasmussen

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2017

Nice!!!! Works on frontend and backend. Great first iteration, probably totally fine to ship!

Future improvements would be to bring the alignments and the responsive stuff to this one, just like we have them for video embeds. 👍 👍

@youknowriad youknowriad force-pushed the add/video-block branch from 254b071 to 5f99993 Aug 9, 2017

@codecov

This comment has been minimized.

Copy link

commented Aug 9, 2017

Codecov Report

Merging #2309 into master will increase coverage by 0.01%.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2309      +/-   ##
==========================================
+ Coverage   25.37%   25.39%   +0.01%     
==========================================
  Files         151      152       +1     
  Lines        4705     4718      +13     
  Branches      792      794       +2     
==========================================
+ Hits         1194     1198       +4     
- Misses       2969     2976       +7     
- Partials      542      544       +2
Impacted Files Coverage Δ
blocks/library/video/index.js 30.76% <30.76%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8d0ca4...5f99993. Read the comment docs.

@youknowriad youknowriad merged commit 60001ba into master Aug 10, 2017

3 checks passed

codecov/project 25.39% (+0.01%) compared to a8d0ca4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the add/video-block branch Aug 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.