New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks registration - Change Lodash's FindIndex with Some. Removed redundant string check. #2332

Merged
merged 3 commits into from Aug 16, 2017

Conversation

Projects
None yet
2 participants
@kuoko
Contributor

kuoko commented Aug 10, 2017

Addressing @aduth's suggestions
#2316 (comment)

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 10, 2017

Codecov Report

Merging #2332 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2332      +/-   ##
=========================================
- Coverage   26.44%   26.4%   -0.05%     
=========================================
  Files         157     157              
  Lines        4851    4848       -3     
  Branches      819     818       -1     
=========================================
- Hits         1283    1280       -3     
  Misses       3015    3015              
  Partials      553     553
Impacted Files Coverage Δ
blocks/api/registration.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8c8078...7832624. Read the comment docs.

codecov bot commented Aug 10, 2017

Codecov Report

Merging #2332 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2332      +/-   ##
=========================================
- Coverage   26.44%   26.4%   -0.05%     
=========================================
  Files         157     157              
  Lines        4851    4848       -3     
  Branches      819     818       -1     
=========================================
- Hits         1283    1280       -3     
  Misses       3015    3015              
  Partials      553     553
Impacted Files Coverage Δ
blocks/api/registration.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8c8078...7832624. Read the comment docs.

@aduth

Can you remove the package-lock.json from your committed changes? We should plan to include this soon, but it's not relevant to the scope of your pull request.

@kuoko

This comment has been minimized.

Show comment
Hide comment
@kuoko

kuoko Aug 16, 2017

Contributor

Hi @aduth,
thanks for your feedback.
I've removed the unecessary file from the pull request.

Contributor

kuoko commented Aug 16, 2017

Hi @aduth,
thanks for your feedback.
I've removed the unecessary file from the pull request.

@aduth

aduth approved these changes Aug 16, 2017

Looks great!

@aduth aduth merged commit 1cc450f into WordPress:master Aug 16, 2017

2 checks passed

codecov/project Absolute coverage decreased by -0.04% but relative coverage increased by +73.55% compared to c8c8078
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment