Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UI tests to unsupported block editor #23729

Merged
merged 4 commits into from Oct 16, 2020
Merged

Add UI tests to unsupported block editor #23729

merged 4 commits into from Oct 16, 2020

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Jul 6, 2020 •
edited

Description

After the unsupported block editor was enabled on all mobile builds, this PR adds UI tests to ensure the functionality is working as expected. (This couldn't be added before editor was made available on non-dev builds.)

The UI tests check:

  • That tapping on the help button of an unsupported block shows the bottom sheet.
  • That tapping on the edit button in the bottom sheet shows the unsupported block web view editor.

How has this been tested?

I've ran the tests locally and visually verified that the UI test runs as described above. Also, if all tests pass on this PR, these tests have succeeded.

To check on iOS locally, from inside the gutenberg folder, run:

npm run native test:e2e:ios:local __device-tests__/gutenberg-editor-unsupported-blocks.test.js

To check on Android locally, from inside the gutenberg folder, run:

npm run native test:e2e:android:local __device-tests__/gutenberg-editor-unsupported-blocks.test.js

Screenshots

Android iOS

Types of changes

This PR only adds UI tests.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@guarani guarani added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jul 6, 2020
@guarani guarani requested review from etoledom and marecar3 July 6, 2020 23:39
@guarani guarani self-assigned this Jul 6, 2020
@guarani guarani mentioned this pull request Jul 6, 2020
Closed
2 tasks
@github-actions
Copy link

github-actions bot commented Jul 6, 2020 •
edited

Size Change: -53 B (0%)

Total Size: 1.19 MB

Filename Size Change
build/block-library/index.js 142 kB -53 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.54 kB 0 B
build/api-fetch/index.js 3.35 kB 0 B
build/autop/index.js 2.72 kB 0 B
build/blob/index.js 668 B 0 B
build/block-directory/index.js 8.6 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 130 kB 0 B
build/block-editor/style-rtl.css 11 kB 0 B
build/block-editor/style.css 10.9 kB 0 B
build/block-library/editor-rtl.css 8.65 kB 0 B
build/block-library/editor.css 8.65 kB 0 B
build/block-library/style-rtl.css 7.71 kB 0 B
build/block-library/style.css 7.71 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-default-parser/index.js 1.77 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.6 kB 0 B
build/components/index.js 169 kB 0 B
build/components/style-rtl.css 15.4 kB 0 B
build/components/style.css 15.4 kB 0 B
build/compose/index.js 9.63 kB 0 B
build/core-data/index.js 12.1 kB 0 B
build/data-controls/index.js 684 B 0 B
build/data/index.js 8.63 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 4.43 kB 0 B
build/edit-navigation/index.js 10.6 kB 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-post/style-rtl.css 6.37 kB 0 B
build/edit-post/style.css 6.35 kB 0 B
build/edit-site/index.js 21.6 kB 0 B
build/edit-site/style-rtl.css 3.8 kB 0 B
build/edit-site/style.css 3.81 kB 0 B
build/edit-widgets/index.js 21.6 kB 0 B
build/edit-widgets/style-rtl.css 3.09 kB 0 B
build/edit-widgets/style.css 3.09 kB 0 B
build/editor/editor-styles-rtl.css 480 B 0 B
build/editor/editor-styles.css 482 B 0 B
build/editor/index.js 42.6 kB 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.84 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.49 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 1.74 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.54 kB 0 B
build/is-shallow-equal/index.js 709 B 0 B
build/keyboard-shortcuts/index.js 2.39 kB 0 B
build/keycodes/index.js 1.85 kB 0 B
build/list-reusable-blocks/index.js 3.02 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.12 kB 0 B
build/notices/index.js 1.69 kB 0 B
build/nux/index.js 3.27 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.44 kB 0 B
build/primitives/index.js 1.35 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/reusable-blocks/index.js 3.04 kB 0 B
build/rich-text/index.js 13 kB 0 B
build/server-side-render/index.js 2.6 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.24 kB 0 B
build/url/index.js 4.07 kB 0 B
build/viewport/index.js 1.75 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@guarani guarani marked this pull request as ready for review July 6, 2020 23:48
@guarani guarani mentioned this pull request Jul 6, 2020
Open
26 tasks
guarani and others added 3 commits October 16, 2020 15:15
@guarani @etoledom
Add UI tests to unsupported block editor
e057f39 
Test that tapping on the help button of an unsupported block shows the bottom sheet. Tapping on the edit button in the bottom sheet shows the unsupported block web view editor.
@guarani @etoledom
Revert UI device capability change
c0930b3 
Reverted the description of the device used for iOS UI tests back from iOS 13.5 to iOS 13.4
@etoledom
Update UBE UI Test with the latest changes from masr
33c68a6
@etoledom etoledom force-pushed the rnmobile/unsupported-fallback-spike-ui-tests branch from 8490a79 to 33c68a6 Compare October 16, 2020 13:32
etoledom
etoledom approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and CI is ✅
Thank you @guarani for this great job!

Finally merging 🎉

@etoledom etoledom merged commit 70b12e0 into master Oct 16, 2020
@etoledom etoledom deleted the rnmobile/unsupported-fallback-spike-ui-tests branch October 16, 2020 19:39
@github-actions github-actions bot added this to the Gutenberg 9.2 milestone Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

@marecar3 marecar3 Awaiting requested review from marecar3

Assignees

@guarani guarani

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 9.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guarani @etoledom