New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove target="_blank" from View Post message #2378

Merged
merged 1 commit into from Aug 11, 2017

Conversation

Projects
None yet
2 participants
@aaronjorbin
Member

aaronjorbin commented Aug 11, 2017

WordPress core removed target="_blank" from most of core: https://core.trac.wordpress.org/ticket/23432

WordPress core also has standardized around "Previews are new windows, views are not": https://core.trac.wordpress.org/browser/trunk/src/wp-admin/edit-form-advanced.php#L92

Related: #1105
cc/ @afercia

Remove target="_blank" from View Post message
WordPress core removed target="_blank" from most of core: https://core.trac.wordpress.org/ticket/23432

WordPress core also has standardized around "Previews are new windows, views are not": https://core.trac.wordpress.org/browser/trunk/src/wp-admin/edit-form-advanced.php#L92
@afercia

This comment has been minimized.

Show comment
Hide comment
@afercia

afercia Aug 11, 2017

Contributor

I'm so used to use Shift + Cmd + Click that I didn't notice this. For reference:

screen shot 2017-08-11 at 23 25 32

It would be nice to see Gutenberg follow the established patterns in core, they're there for good reasons.

Contributor

afercia commented Aug 11, 2017

I'm so used to use Shift + Cmd + Click that I didn't notice this. For reference:

screen shot 2017-08-11 at 23 25 32

It would be nice to see Gutenberg follow the established patterns in core, they're there for good reasons.

@afercia afercia merged commit 961e987 into WordPress:master Aug 11, 2017

2 checks passed

codecov/project 25.9% remains the same compared to bd502be
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment