New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with inline toolbar shadow #2396

Merged
merged 2 commits into from Aug 14, 2017

Conversation

Projects
None yet
2 participants
@jasmussen
Contributor

jasmussen commented Aug 14, 2017

0.8 included a new unified toolbar design for the quick toolbar. I missed here, a regression with the inline toolbar (shown on Cover Image and Image captions). The regression was that the shadow was gone. This PR fixes that.

Screenshot:

screen shot 2017-08-14 at 12 01 51

Fix regression with inline toolbar shadow
0.8 included a new unified toolbar design for the quick toolbar. I missed here, a regression with the inline toolbar (shown on Cover Image and Image captions). This PR fixes that.

@jasmussen jasmussen self-assigned this Aug 14, 2017

@jasmussen jasmussen requested a review from youknowriad Aug 14, 2017

@youknowriad

Small note but LGTM 👍

@jasmussen jasmussen merged commit 9f7f1bb into master Aug 14, 2017

3 checks passed

codecov/project 25.9% remains the same compared to 5ce51a8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jasmussen jasmussen deleted the fix/inline-toolbar-shadow branch Aug 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment