New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Block: Fix dropping images on the image block #2399

Merged
merged 1 commit into from Aug 14, 2017

Conversation

Projects
None yet
2 participants
@youknowriad
Contributor

youknowriad commented Aug 14, 2017

closes #2388

Fixes a small regression introduced in #2294

@youknowriad youknowriad self-assigned this Aug 14, 2017

@youknowriad youknowriad requested review from mkaz and jasmussen Aug 14, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 14, 2017

Codecov Report

Merging #2399 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2399      +/-   ##
==========================================
- Coverage   25.91%   25.91%   -0.01%     
==========================================
  Files         157      157              
  Lines        4850     4851       +1     
  Branches      820      820              
==========================================
  Hits         1257     1257              
- Misses       3033     3034       +1     
  Partials      560      560
Impacted Files Coverage Δ
blocks/library/image/index.js 15% <0%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f7f1bb...3b11ff1. Read the comment docs.

codecov bot commented Aug 14, 2017

Codecov Report

Merging #2399 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2399      +/-   ##
==========================================
- Coverage   25.91%   25.91%   -0.01%     
==========================================
  Files         157      157              
  Lines        4850     4851       +1     
  Branches      820      820              
==========================================
  Hits         1257     1257              
- Misses       3033     3034       +1     
  Partials      560      560
Impacted Files Coverage Δ
blocks/library/image/index.js 15% <0%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f7f1bb...3b11ff1. Read the comment docs.

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Aug 14, 2017

Contributor

Nice! Dragging and dropping an image file onto the image block placeholder works for me. 👍 👍

Contributor

jasmussen commented Aug 14, 2017

Nice! Dragging and dropping an image file onto the image block placeholder works for me. 👍 👍

@youknowriad youknowriad merged commit fe9d0fd into master Aug 14, 2017

3 checks passed

codecov/project 25.91% (-0.01%) compared to 9f7f1bb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/drop-image branch Aug 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment