New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks: Fix inserting a pull quote #2400

Merged
merged 1 commit into from Aug 14, 2017

Conversation

Projects
None yet
3 participants
@youknowriad
Contributor

youknowriad commented Aug 14, 2017

not sure where this regression was introduced, but we need to check if the value is defined before looping over it.

An alternative could be using a default value.

closes #2398

@youknowriad youknowriad self-assigned this Aug 14, 2017

@youknowriad youknowriad requested a review from karmatosed Aug 14, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 14, 2017

Codecov Report

Merging #2400 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2400   +/-   ##
=======================================
  Coverage   25.91%   25.91%           
=======================================
  Files         157      157           
  Lines        4850     4850           
  Branches      820      821    +1     
=======================================
  Hits         1257     1257           
  Misses       3033     3033           
  Partials      560      560
Impacted Files Coverage Δ
blocks/library/pullquote/index.js 33.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f7f1bb...77a722f. Read the comment docs.

codecov bot commented Aug 14, 2017

Codecov Report

Merging #2400 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2400   +/-   ##
=======================================
  Coverage   25.91%   25.91%           
=======================================
  Files         157      157           
  Lines        4850     4850           
  Branches      820      821    +1     
=======================================
  Hits         1257     1257           
  Misses       3033     3033           
  Partials      560      560
Impacted Files Coverage Δ
blocks/library/pullquote/index.js 33.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f7f1bb...77a722f. Read the comment docs.

@karmatosed

Thanks for this, no white screen happening now.

@youknowriad youknowriad merged commit 77fa928 into master Aug 14, 2017

3 checks passed

codecov/project 25.91% (+0%) compared to 9f7f1bb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/inserting-pullquote branch Aug 14, 2017

@aduth

This comment has been minimized.

Show comment
Hide comment
@aduth

aduth Aug 14, 2017

Member

Similar: #2356

Member

aduth commented Aug 14, 2017

Similar: #2356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment