New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display nicer URLs when editing a link #2401

Merged
merged 4 commits into from Aug 17, 2017

Conversation

Projects
None yet
3 participants
@notnownikki
Member

notnownikki commented Aug 14, 2017

Filters the URL for display by removing protocol, www subdomain, and if there path is '/', the trailing slash.

@notnownikki

This comment has been minimized.

Show comment
Hide comment
@notnownikki
Member

notnownikki commented Aug 14, 2017

Fixes #2174

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 14, 2017

Codecov Report

Merging #2401 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2401      +/-   ##
==========================================
+ Coverage   26.51%   26.58%   +0.06%     
==========================================
  Files         158      158              
  Lines        4853     4857       +4     
  Branches      816      817       +1     
==========================================
+ Hits         1287     1291       +4     
  Misses       3013     3013              
  Partials      553      553
Impacted Files Coverage Δ
blocks/editable/format-toolbar/index.js 7.5% <ø> (ø) ⬆️
blocks/url-input/button.js 0% <ø> (ø) ⬆️
editor/utils/url.js 66.66% <100%> (+66.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03bd015...dd5a2fc. Read the comment docs.

codecov bot commented Aug 14, 2017

Codecov Report

Merging #2401 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2401      +/-   ##
==========================================
+ Coverage   26.51%   26.58%   +0.06%     
==========================================
  Files         158      158              
  Lines        4853     4857       +4     
  Branches      816      817       +1     
==========================================
+ Hits         1287     1291       +4     
  Misses       3013     3013              
  Partials      553      553
Impacted Files Coverage Δ
blocks/editable/format-toolbar/index.js 7.5% <ø> (ø) ⬆️
blocks/url-input/button.js 0% <ø> (ø) ⬆️
editor/utils/url.js 66.66% <100%> (+66.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03bd015...dd5a2fc. Read the comment docs.

Show outdated Hide outdated editor/utils/url.js Outdated
@notnownikki

This comment has been minimized.

Show comment
Hide comment
@notnownikki

notnownikki Aug 17, 2017

Member

Conflict fixed.

Member

notnownikki commented Aug 17, 2017

Conflict fixed.

@mtias

This comment has been minimized.

Show comment
Hide comment
@mtias

mtias Aug 17, 2017

Contributor

Looking good to me.

Contributor

mtias commented Aug 17, 2017

Looking good to me.

@notnownikki notnownikki merged commit d585c55 into master Aug 17, 2017

3 checks passed

codecov/project 26.58% (+0.06%) compared to 03bd015
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mtias mtias deleted the update/hide-protocol-in-links branch Aug 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment