Adds 'Heading and paragraph' pattern #24143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enriquesanchez
added
Backport to WP Beta/RC
enriquesanchez
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
|
The extra spaces here in between the number and the title seem a little odd to me. Perhaps we can try just a line break instead?
It would be even better visually if we added some space, but this is a little hard to achieve with the proper spacing right now. That first "2." line, would need a line spacing value of
|
enriquesanchez
force-pushed
the
Adds-heading-and-a-paragraph-pattern
branch
from
21c54de
to
d6c8977
Compare
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
|
Thanks @kjellr I've updated it following your suggestion of adding a line break. Not sure why I didn't think of that! ;D Making the chapter number it's own block introduces a lot of space on some themes, particularly at that big of a size. I found it's less noticeable if we also use a heading block for the chapter number, but having two heading blocks one after the other introduces some semantic issues. So decided to go with your first suggestion.
|
youknowriad
removed
the
Backport to WP Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new 'Heading and paragraph' pattern: