New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds 'Heading and paragraph' pattern #24143
Conversation
The extra spaces here in between the number and the title seem a little odd to me. Perhaps we can try just a line break instead? It would be even better visually if we added some space, but this is a little hard to achieve with the proper spacing right now. That first "2." line, would need a line spacing value of |
21c54de
to
d6c8977
Compare
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
Thanks @kjellr I've updated it following your suggestion of adding a line break. Not sure why I didn't think of that! ;D Making the chapter number it's own block introduces a lot of space on some themes, particularly at that big of a size. I found it's less noticeable if we also use a heading block for the chapter number, but having two heading blocks one after the other introduces some semantic issues. So decided to go with your first suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adds a new 'Heading and paragraph' pattern: