New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish gallery, fix crop in Safari #2422

Merged
merged 4 commits into from Aug 15, 2017

Conversation

Projects
None yet
2 participants
@jasmussen
Contributor

jasmussen commented Aug 15, 2017

This polishes the gallery block by vertically centering uncropped images, and fixing an issue where in Safari, images weren't cropped.

It also probably fixes #2337, but we need to test that.

jasmussen added some commits Aug 15, 2017

Add explicit "auto" height to uncropped images.
This may possibly address #2337, but not sure.
Fix gallery crop not working in Safari.
Let it be known that Matías Ventura is a flex genius.

@jasmussen jasmussen self-assigned this Aug 15, 2017

@jasmussen jasmussen requested a review from youknowriad Aug 15, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 15, 2017

Codecov Report

Merging #2422 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2422      +/-   ##
==========================================
- Coverage   26.44%   26.21%   -0.24%     
==========================================
  Files         157      157              
  Lines        4851     4940      +89     
  Branches      819      841      +22     
==========================================
+ Hits         1283     1295      +12     
- Misses       3015     3073      +58     
- Partials      553      572      +19
Impacted Files Coverage Δ
blocks/library/paragraph/index.js 39.28% <0%> (-7.78%) ⬇️
blocks/api/paste.js 90.24% <0%> (-7.13%) ⬇️
blocks/library/heading/index.js 22.85% <0%> (-0.96%) ⬇️
blocks/library/list/index.js 6.55% <0%> (-0.42%) ⬇️
blocks/library/image/index.js 15.38% <0%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39c6bfc...40bc9b6. Read the comment docs.

codecov bot commented Aug 15, 2017

Codecov Report

Merging #2422 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2422      +/-   ##
==========================================
- Coverage   26.44%   26.21%   -0.24%     
==========================================
  Files         157      157              
  Lines        4851     4940      +89     
  Branches      819      841      +22     
==========================================
+ Hits         1283     1295      +12     
- Misses       3015     3073      +58     
- Partials      553      572      +19
Impacted Files Coverage Δ
blocks/library/paragraph/index.js 39.28% <0%> (-7.78%) ⬇️
blocks/api/paste.js 90.24% <0%> (-7.13%) ⬇️
blocks/library/heading/index.js 22.85% <0%> (-0.96%) ⬇️
blocks/library/list/index.js 6.55% <0%> (-0.42%) ⬇️
blocks/library/image/index.js 15.38% <0%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39c6bfc...40bc9b6. Read the comment docs.

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Aug 15, 2017

Contributor

🎉

Contributor

jasmussen commented Aug 15, 2017

🎉

@jasmussen jasmussen merged commit acde984 into master Aug 15, 2017

3 checks passed

codecov/project 26.21% (-0.24%) compared to 39c6bfc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jasmussen jasmussen deleted the polish/gallery branch Aug 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment