New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the confirmation shown when publishing a new post #2437

Merged
merged 1 commit into from Aug 16, 2017

Conversation

Projects
None yet
3 participants
@youknowriad
Contributor

youknowriad commented Aug 16, 2017

No description provided.

@youknowriad youknowriad self-assigned this Aug 16, 2017

@youknowriad youknowriad requested review from mtias and jasmussen Aug 16, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 16, 2017

Codecov Report

Merging #2437 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2437      +/-   ##
==========================================
+ Coverage   26.54%   26.55%   +0.01%     
==========================================
  Files         157      157              
  Lines        4853     4851       -2     
  Branches      818      816       -2     
==========================================
  Hits         1288     1288              
  Misses       3012     3012              
+ Partials      553      551       -2
Impacted Files Coverage Δ
editor/header/tools/publish-button.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3947282...6c15b30. Read the comment docs.

codecov bot commented Aug 16, 2017

Codecov Report

Merging #2437 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2437      +/-   ##
==========================================
+ Coverage   26.54%   26.55%   +0.01%     
==========================================
  Files         157      157              
  Lines        4853     4851       -2     
  Branches      818      816       -2     
==========================================
  Hits         1288     1288              
  Misses       3012     3012              
+ Partials      553      551       -2
Impacted Files Coverage Δ
editor/header/tools/publish-button.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3947282...6c15b30. Read the comment docs.

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Aug 16, 2017

Contributor

Nice! Works as expected. I think this should go in 0.9. @mtias any objections? 👍 👍 from me.

Contributor

jasmussen commented Aug 16, 2017

Nice! Works as expected. I think this should go in 0.9. @mtias any objections? 👍 👍 from me.

@mtias mtias merged commit bbd0fc3 into master Aug 16, 2017

3 checks passed

codecov/project 26.55% (+0.01%) compared to 3947282
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the remove/publish-notice branch Aug 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment