New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try sliding toolbar for overflow on mobile #2443

Merged
merged 1 commit into from Aug 18, 2017

Conversation

Projects
None yet
2 participants
@jasmussen
Contributor

jasmussen commented Aug 17, 2017

This PR may fix #2287, at least partially, or in a transitional way. It's a two-line code change, and all it does is ensure that on mobile, overflow can be scrolled.

This is not a good solution for desktop, of course, where the scrollbar when visible (as it is on nearly all computers) would not only cover content and be ugly, but scrolling horizontally is generally not a good experience. However on mobile, the scrollbar fades in briefly when you load the page, and you can just drag with your finger.

Let's discuss whether this is a good solution.

Demo:

slidingtoolbar

Try sliding toolbar for overflow on mobile
This PR may fix #2287, at least partially, or in a transitional way. It's a two-line code change, and all it does is ensure that on mobile, overflow can be scrolled.

This is not a good solution for desktop, of course, where the scrollbar when visible (as it is on nearly all computers) would not only cover content and be ugly, but scrolling horizontally is generally not a good experience. However on mobile, the scrollbar fades in briefly when you load the page, and you can just drag with your finger.

Let's discuss whether this is a good solution.
@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Aug 17, 2017

Contributor

Here's how the Android app does it: https://cloudup.com/c9O9cRkfx0K

Contributor

jasmussen commented Aug 17, 2017

Here's how the Android app does it: https://cloudup.com/c9O9cRkfx0K

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Aug 18, 2017

Contributor

Merging because the tests pass, it's a trivial change, and I got a thumbs up in chat!

Contributor

jasmussen commented Aug 18, 2017

Merging because the tests pass, it's a trivial change, and I got a thumbs up in chat!

@jasmussen jasmussen merged commit f777f79 into master Aug 18, 2017

3 checks passed

codecov/project 26.51% remains the same compared to 038f49a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jasmussen jasmussen deleted the try/sliding-mobile-toolbar branch Aug 18, 2017

@EphoxJames

This comment has been minimized.

Show comment
Hide comment
@EphoxJames

EphoxJames Aug 22, 2017

Contributor

:-(
This broke the drop-down menu.

Contributor

EphoxJames commented on 1c8d2ec Aug 22, 2017

:-(
This broke the drop-down menu.

@EphoxJames

This comment has been minimized.

Show comment
Hide comment
@EphoxJames

EphoxJames Aug 22, 2017

Contributor

Right, the only way I can see to make the drop-down menu work again is to set the position using Javascript.

Contributor

EphoxJames commented Aug 22, 2017

Right, the only way I can see to make the drop-down menu work again is to set the position using Javascript.

@EphoxJames

This comment has been minimized.

Show comment
Hide comment
@EphoxJames

EphoxJames Aug 22, 2017

Contributor

Because it relied on being able to position relative to the button and now the button does not allow any overflow. The only reason the block switcher still works is that it always ignored the position of the button when displaying the drop-down.

Contributor

EphoxJames commented Aug 22, 2017

Because it relied on being able to position relative to the button and now the button does not allow any overflow. The only reason the block switcher still works is that it always ignored the position of the button when displaying the drop-down.

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Aug 22, 2017

Contributor

Going to try something, I have an idea.

Contributor

jasmussen commented Aug 22, 2017

Going to try something, I have an idea.

EphoxJames added a commit that referenced this pull request Aug 22, 2017

EphoxJames added a commit that referenced this pull request Aug 29, 2017

Merge pull request #2492 from WordPress/fix/drop-down-menu-trapped-by…
…-overflow-none

Fix bug introduced by #2443 where drop-down menu can't display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment