New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to select an individual heading block from the ToC #2446

Merged
merged 2 commits into from Aug 17, 2017

Conversation

Projects
None yet
2 participants
@mtias
Contributor

mtias commented Aug 17, 2017

This allows selecting a heading in the table of contents panel and having the corresponding block selected in the body, so it works as a way to navigate through a post using these landmarks.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 17, 2017

Codecov Report

Merging #2446 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2446      +/-   ##
==========================================
- Coverage   26.58%   26.49%   -0.09%     
==========================================
  Files         158      158              
  Lines        4857     4884      +27     
  Branches      817      823       +6     
==========================================
+ Hits         1291     1294       +3     
- Misses       3013     3031      +18     
- Partials      553      559       +6
Impacted Files Coverage Δ
editor/sidebar/table-of-contents/index.js 0% <0%> (ø) ⬆️
editor/sidebar/table-of-contents/item.js 0% <0%> (ø) ⬆️
blocks/editable/format-toolbar/index.js 10% <0%> (+2.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7458e8...cd3b5c5. Read the comment docs.

codecov bot commented Aug 17, 2017

Codecov Report

Merging #2446 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2446      +/-   ##
==========================================
- Coverage   26.58%   26.49%   -0.09%     
==========================================
  Files         158      158              
  Lines        4857     4884      +27     
  Branches      817      823       +6     
==========================================
+ Hits         1291     1294       +3     
- Misses       3013     3031      +18     
- Partials      553      559       +6
Impacted Files Coverage Δ
editor/sidebar/table-of-contents/index.js 0% <0%> (ø) ⬆️
editor/sidebar/table-of-contents/item.js 0% <0%> (ø) ⬆️
blocks/editable/format-toolbar/index.js 10% <0%> (+2.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7458e8...cd3b5c5. Read the comment docs.

@mtias mtias merged commit 9b5b9d6 into master Aug 17, 2017

3 checks passed

codecov/project 26.49% (-0.09%) compared to e7458e8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mtias mtias deleted the add/ability-to-focus-heading-toc branch Aug 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment