New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arrow key navigation temporarily so link boundaries work again #2453

Merged
merged 1 commit into from Aug 18, 2017

Conversation

Projects
None yet
2 participants
@iseulde
Member

iseulde commented Aug 17, 2017

No description provided.

@iseulde iseulde requested a review from mtias Aug 17, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 17, 2017

Codecov Report

Merging #2453 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2453      +/-   ##
==========================================
+ Coverage   26.75%   26.77%   +0.02%     
==========================================
  Files         158      158              
  Lines        4882     5049     +167     
  Branches      820      877      +57     
==========================================
+ Hits         1306     1352      +46     
- Misses       3023     3100      +77     
- Partials      553      597      +44
Impacted Files Coverage Δ
editor/modes/visual-editor/block.js 0% <0%> (ø) ⬆️
blocks/editable/index.js 9.57% <0%> (-1.54%) ⬇️
blocks/api/paste/normalise-blocks.js 95.74% <0%> (-0.93%) ⬇️
editor/sidebar/table-of-contents/item.js 0% <0%> (ø) ⬆️
blocks/api/paste/strip-attributes.js 100% <0%> (ø) ⬆️
blocks/api/paste/strip-wrappers.js 100% <0%> (ø) ⬆️
editor/sidebar/table-of-contents/index.js 0% <0%> (ø) ⬆️
blocks/api/paste/index.js 100% <0%> (ø) ⬆️
blocks/editable/format-toolbar/index.js 10% <0%> (+2.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de51e24...488ea2d. Read the comment docs.

codecov bot commented Aug 17, 2017

Codecov Report

Merging #2453 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2453      +/-   ##
==========================================
+ Coverage   26.75%   26.77%   +0.02%     
==========================================
  Files         158      158              
  Lines        4882     5049     +167     
  Branches      820      877      +57     
==========================================
+ Hits         1306     1352      +46     
- Misses       3023     3100      +77     
- Partials      553      597      +44
Impacted Files Coverage Δ
editor/modes/visual-editor/block.js 0% <0%> (ø) ⬆️
blocks/editable/index.js 9.57% <0%> (-1.54%) ⬇️
blocks/api/paste/normalise-blocks.js 95.74% <0%> (-0.93%) ⬇️
editor/sidebar/table-of-contents/item.js 0% <0%> (ø) ⬆️
blocks/api/paste/strip-attributes.js 100% <0%> (ø) ⬆️
blocks/api/paste/strip-wrappers.js 100% <0%> (ø) ⬆️
editor/sidebar/table-of-contents/index.js 0% <0%> (ø) ⬆️
blocks/api/paste/index.js 100% <0%> (ø) ⬆️
blocks/editable/format-toolbar/index.js 10% <0%> (+2.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de51e24...488ea2d. Read the comment docs.

@mtias mtias merged commit be9cb7b into master Aug 18, 2017

3 checks passed

codecov/project 26.77% (+0.02%) compared to de51e24
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mtias mtias deleted the remove/arrow-nav branch Aug 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment