Add/block navigation component readme #24882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinyAhin
added
the
[Type] Developer Documentation
youknowriad
reviewed
Aug 31, 2020
|
|
||
| const MyNavigation = () => <BlockNavigation | ||
| onSelect={ onClose } | ||
| __experimentalFeatures={ __experimentalFeatures } |
There was a problem hiding this comment.
Should we document experimental things? It seems we shouldn't as they are not ready yet.
There was a problem hiding this comment.
I think so also.
We can always update this when the feature is more advanced.
That's why I finally removed it from the code sample.
mkaz
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added documentation for the block navigation component (see #22891)
How has this been tested?
N/A, documentation only
Types of changes
Documentation
Checklist: