New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade TypeScript to v4 #24892
Merged
Merged
Upgrade TypeScript to v4 #24892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +149 B (0%) Total Size: 1.18 MB
ℹ️ View Unchanged
|
a2a8de2
to
487a83f
Compare
|
Rebased and upgraded to latest 4.0.3. |
ockham
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good and testing well! One note, otherwise good to merge!
Co-authored-by: Zebulan Stanphill <zebulanstanphill@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs Technical Feedback
Needs testing from a developer perspective.
npm Packages
Related to npm packages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade TypeScript dependency to version 4.
Read the announcement here.
Applies a new feature
noEmitwithincrementalto thebin/directory typings. These typings were discarded before, this change prevents them from being produced at all.How has this been tested?
Types continue to be generated as expected. The following completes without issues:
Types are generated as expected, e.g.
packages/warning/build-types/index.d.ts:Types of changes
Internal.
Checklist: