Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[Button Block] Allow for text to wrap #2502
Conversation
jahvi
referenced this pull request
Aug 22, 2017
Closed
Wrap button if long single line of text and depending on screen sizes #2249
jahvi
changed the title
Allow for multi line text in button block
[Button Block] Allow for multi line text in button block
Aug 22, 2017
jahvi
changed the title
[Button Block] Allow for multi line text in button block
[Button Block] Allow for multi line text
Aug 22, 2017
iseulde
added
the
[Type] Bug
label
Aug 22, 2017
iseulde
changed the title
[Button Block] Allow for multi line text
[Button Block] Allow for text to wrap
Aug 22, 2017
iseulde
added
the
Needs Design Feedback
label
Aug 22, 2017
This comment has been minimized.
This comment has been minimized.
anna-harrison
commented
Aug 24, 2017
The buttons in the screenshots above look ok to me design wise /cc @karmatosed |
This comment has been minimized.
This comment has been minimized.
@jahvi interesting, have you tried this on various browsers? My concern is depending on device/browser this may not hold up. |
karmatosed
removed
the
Needs Design Feedback
label
Aug 25, 2017
jahvi
force-pushed the
jahvi:update/multi-line-button
branch
2 times, most recently
from
b41f878
to
036bd96
Aug 27, 2017
This comment has been minimized.
This comment has been minimized.
@karmatosed Yes, it's a relatively simple change in its core so it looks good in all browser/devices, here's a quick report (I feel like the text should always be aligned to the center in the frontend though, not sure if there's a reason for it or just an oversight): Comparison ScreenshotsChrome
Firefox
Safari
Edge
IE 11
Mobile
I also noticed the URL input component overlapped the button in the editor when it had more than one line so I fixed that as well. My only thought is that the $blocks-button__height variable is only used to calculate the button's border radius now, not the height and line-height as before so I'm wondering if I should get rid of it entirely and hardcode its value.
|
youknowriad
force-pushed the
jahvi:update/multi-line-button
branch
from
036bd96
to
02de796
Dec 22, 2017
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Dec 22, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #2502 +/- ##
=========================================
- Coverage 39.08% 30.2% -8.88%
=========================================
Files 290 174 -116
Lines 6967 5270 -1697
Branches 1273 900 -373
=========================================
- Hits 2723 1592 -1131
+ Misses 3570 3121 -449
+ Partials 674 557 -117
Continue to review full report at Codecov.
|
youknowriad
approved these changes
Dec 22, 2017
Rebased this, I think this is good to go |
jahvi commentedAug 22, 2017
•
edited
This is my attempt to fix #2249
I'm hardcoding the top and bottom padding because I'm not sure if there's a way to get this dynamically based on the
$blocks-button__height
and maybe the font size?