Hide the quick side inserter when the user is typing #25548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtias
added
[Status] In Progress
|
Size Change: +4 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
|
This works as advertised, I was thinking this was the expected behavior :) It seems there's a failing e2e tests, we may want to add a call to move the mouse before opening the inserter there as it might be hidden now. |
jasmussen
approved these changes
Sep 23, 2020
|
I don't remember if we intended the current behaviour because so much has changed, but it makes sense to preserve the is typing flair when you come from adding new lines of text. |
|
I just have a vague recollection of writing some is-typing specific CSS to accomplish the same, but it must've not come to pass. |
|
Right, it's also trickier to keep state in CSS |
This covers cases where on entering a new line the + would flash into appearance and out again
ntsekouras
force-pushed
the
update/hide-side-inserter-when-typing
branch
from
3244276
to
9ed0066
Compare
mtias
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweak covers cases where on entering a new line (pressing Enter) the [+] would become briefly visible before disappearing again with the first characters typed.