Set default link for images using image_default_link_type option #25578
Merged
Set default link for images using image_default_link_type option #25578
Conversation
|
Size Change: +121 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
mkaz
changed the title
mkaz
requested review from
ajitbohra,
ajlende,
nerrad,
ntwb and
talldan
as code owners
12 tasks
ajlende
reviewed
Sep 23, 2020
mkaz
force-pushed
the
fix/10173-image_default_link_type
branch
from
e711561 to
d56b084
Compare
Contributor
|
Tested using "file" & "post" and this is working as expected. |
mkaz
changed the title
|
Thanks |
|
can i disable images inserting from url? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use the option for image_default_link_type to set default link for images.
The related PR for galleries is #25582
Fixes #10173
How has this been tested?
image_default_link_typeto "file" or "post"You can set by going to your site's
wp-admin/options.phppage or via a plugin using a function like:Types of changes
This unsets the default link type in Gutenberg none in favor of the WordPress option default. It checks to see if the option is set and sets the linkDestination based on the option.
There is an unfortunate mismtach between what Gutenberg thinks the option should be and what the historic option values are. The classic editor and previous use
fileto represent Media File, andpostto represent "Attachment Page". The Gutenberg constants used aremediaandattachment.