Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default link for images using image_default_link_type option #25578

Merged
merged 9 commits into from
Sep 24, 2020
Merged

Set default link for images using image_default_link_type option #25578

merged 9 commits into from
Sep 24, 2020
+51 −27

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented Sep 23, 2020 •
edited
Loading

Description

Use the option for image_default_link_type to set default link for images.
The related PR for galleries is #25582

Fixes #10173

How has this been tested?

  1. Set the WordPress option image_default_link_type to "file" or "post"
    You can set by going to your site's wp-admin/options.php page or via a plugin using a function like:
add_action( 'after_setup_theme', function() {
    update_option( 'image_default_link_type', 'file' );
});
  1. Add an image in the editor and confirm the default link type is automatically selected.

confirm-media-link

Types of changes

This unsets the default link type in Gutenberg none in favor of the WordPress option default. It checks to see if the option is set and sets the linkDestination based on the option.

There is an unfortunate mismtach between what Gutenberg thinks the option should be and what the historic option values are. The classic editor and previous use file to represent Media File, and post to represent "Attachment Page". The Gutenberg constants used are media and attachment.

@github-actions
Copy link

github-actions bot commented Sep 23, 2020 •
edited
Loading

Size Change: +121 B (0%)

Total Size: 1.17 MB

Filename Size Change
build/block-library/index.js 135 kB +121 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.52 kB 0 B
build/api-fetch/index.js 3.34 kB 0 B
build/autop/index.js 2.72 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 8.53 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 128 kB 0 B
build/block-editor/style-rtl.css 11.1 kB 0 B
build/block-editor/style.css 11.1 kB 0 B
build/block-library/editor-rtl.css 8.56 kB 0 B
build/block-library/editor.css 8.56 kB 0 B
build/block-library/style-rtl.css 7.6 kB 0 B
build/block-library/style.css 7.59 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-default-parser/index.js 1.78 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.5 kB 0 B
build/components/index.js 167 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/compose/index.js 9.42 kB 0 B
build/core-data/index.js 12 kB 0 B
build/data-controls/index.js 1.27 kB 0 B
build/data/index.js 8.43 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 4.42 kB 0 B
build/edit-navigation/index.js 10.4 kB 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-post/style-rtl.css 6.24 kB 0 B
build/edit-post/style.css 6.23 kB 0 B
build/edit-site/index.js 19.7 kB 0 B
build/edit-site/style-rtl.css 3.3 kB 0 B
build/edit-site/style.css 3.3 kB 0 B
build/edit-widgets/index.js 17.5 kB 0 B
build/edit-widgets/style-rtl.css 2.8 kB 0 B
build/edit-widgets/style.css 2.8 kB 0 B
build/editor/editor-styles-rtl.css 492 B 0 B
build/editor/editor-styles.css 493 B 0 B
build/editor/index.js 45.5 kB 0 B
build/editor/style-rtl.css 3.8 kB 0 B
build/editor/style.css 3.8 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.49 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 1.74 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.55 kB 0 B
build/is-shallow-equal/index.js 709 B 0 B
build/keyboard-shortcuts/index.js 2.39 kB 0 B
build/keycodes/index.js 1.85 kB 0 B
build/list-reusable-blocks/index.js 3.02 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.12 kB 0 B
build/notices/index.js 1.69 kB 0 B
build/nux/index.js 3.27 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.44 kB 0 B
build/primitives/index.js 1.34 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13.7 kB 0 B
build/server-side-render/index.js 2.61 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.24 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.74 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@mkaz mkaz changed the title Use the option for image_default_link_type to set default link for images and galleries Use the option for image_default_link_type to set default link for images Sep 23, 2020
@mkaz mkaz mentioned this pull request Sep 23, 2020
Open
@mkaz mkaz added the [Block] Image Affects the Image Block label Sep 23, 2020
@mkaz mkaz marked this pull request as ready for review September 23, 2020 21:03
@ajlende ajlende mentioned this pull request Sep 23, 2020
Merged
12 tasks
@mkaz mkaz force-pushed the fix/10173-image_default_link_type branch from e711561 to d56b084 Compare September 23, 2020 22:51
@StevenDufresne
Copy link
Contributor

Tested using "file" & "post" and this is working as expected.

@mkaz mkaz changed the title Use the option for image_default_link_type to set default link for images Set default link for images using image_default_link_type option Sep 24, 2020
ajlende
ajlende approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@ajlende ajlende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mkaz mkaz merged commit b18a2ff into master Sep 24, 2020
@mkaz mkaz deleted the fix/10173-image_default_link_type branch September 24, 2020 15:58
@github-actions github-actions bot added this to the Gutenberg 9.1 milestone Sep 24, 2020
@mkaz mkaz mentioned this pull request Sep 24, 2020
Closed
@oxyc oxyc mentioned this pull request Sep 30, 2020
Open
@ajlende ajlende mentioned this pull request Oct 7, 2020
Closed
@getsource getsource mentioned this pull request Nov 24, 2020
Open
@SeanDS SeanDS mentioned this pull request Nov 30, 2020
Closed
@miminari miminari mentioned this pull request Dec 8, 2020
Closed
@KaziMahbuburRahman
Copy link

Thanks

@KaziMahbuburRahman
Copy link

can i disable images inserting from url?
I am using a plugin which helps me to upload image directly when I paste image from another site but Wordpress automatically add image from external source which I don't want...
can i turn off anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajlende ajlende ajlende approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
[Block] Image Affects the Image Block
Projects
None yet
Milestone
Gutenberg 9.1
Development

Successfully merging this pull request may close these issues.

image_default_link_type is ignored by Gutenberg
4 participants
@mkaz @StevenDufresne @KaziMahbuburRahman @ajlende