Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default link to image_default_link_type for gallery #25582

Merged
merged 5 commits into from Sep 24, 2020

Conversation

ajlende
Copy link
Contributor

@ajlende ajlende commented Sep 23, 2020

Description

Fixes #10173 for galleries

Related to #25578 which fixes it for images

  • Remove block default linkTo value
  • Use the image_default_link_type option from options.php to set default link for galleries
  • Adjust linkTo attribute to match link values in PHP: 'media''file' and 'attachment''post'
  • Fix shortcode 'post' link transformation (before 'post' wasn't getting transformed to 'attachment' in transforms.js, but now with the block using the same values as the shortcode it doesn't need to be transformed)
  • Update deprecated.js with the attribute change
  • Update transforms.js with the attribute change

How has this been tested?

New gallery block

  1. Change the image_default_link_type setting in options.php to 'post', 'file', or 'none'
  2. Create a gallery block
  3. See that the Link to option is correct: Attachment page for 'post', Media file for 'file' or None for 'none'

Migrate gallery block

  1. Create gallery block off of master branch with various link options
  2. Switch to this branch
  3. See that old gallery block is updated with the new attributes

Transform from shortcode

  1. Create a Classic Editor block
  2. Add gallery in the Classic Editor
  3. Click 'Convert to blocks'
  4. See that the link option in the shortcode goes to the linkTo option in the gallery

Screenshots

image_default_link_type-gallery

Types of changes

New feature? Bug fix?

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@github-actions
Copy link

github-actions bot commented Sep 23, 2020

Size Change: +211 B (0%)

Total Size: 1.17 MB

Filename Size Change
build/block-editor/index.js 128 kB -8 B (0%)
build/block-library/index.js 135 kB +219 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.52 kB 0 B
build/api-fetch/index.js 3.34 kB 0 B
build/autop/index.js 2.72 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 8.53 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/style-rtl.css 11.1 kB 0 B
build/block-editor/style.css 11.1 kB 0 B
build/block-library/editor-rtl.css 8.56 kB 0 B
build/block-library/editor.css 8.56 kB 0 B
build/block-library/style-rtl.css 7.6 kB 0 B
build/block-library/style.css 7.59 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-default-parser/index.js 1.78 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.5 kB 0 B
build/components/index.js 167 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/compose/index.js 9.42 kB 0 B
build/core-data/index.js 12 kB 0 B
build/data-controls/index.js 1.27 kB 0 B
build/data/index.js 8.43 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 4.42 kB 0 B
build/edit-navigation/index.js 10.4 kB 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-post/style-rtl.css 6.24 kB 0 B
build/edit-post/style.css 6.23 kB 0 B
build/edit-site/index.js 19.7 kB 0 B
build/edit-site/style-rtl.css 3.3 kB 0 B
build/edit-site/style.css 3.3 kB 0 B
build/edit-widgets/index.js 17.5 kB 0 B
build/edit-widgets/style-rtl.css 2.8 kB 0 B
build/edit-widgets/style.css 2.8 kB 0 B
build/editor/editor-styles-rtl.css 492 B 0 B
build/editor/editor-styles.css 493 B 0 B
build/editor/index.js 45.5 kB 0 B
build/editor/style-rtl.css 3.8 kB 0 B
build/editor/style.css 3.8 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.49 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 1.74 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.55 kB 0 B
build/is-shallow-equal/index.js 709 B 0 B
build/keyboard-shortcuts/index.js 2.39 kB 0 B
build/keycodes/index.js 1.85 kB 0 B
build/list-reusable-blocks/index.js 3.02 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.12 kB 0 B
build/notices/index.js 1.69 kB 0 B
build/nux/index.js 3.27 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.44 kB 0 B
build/primitives/index.js 1.34 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13.7 kB 0 B
build/server-side-render/index.js 2.61 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.24 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.74 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@ajlende ajlende force-pushed the fix/10173-image_default_link_type-gallery branch from 4b46a54 to 1034c45 Compare September 23, 2020 20:23
@ajlende ajlende marked this pull request as ready for review September 23, 2020 22:35
mkaz
mkaz approved these changes Sep 23, 2020
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Alex, nice working with you on these! 👍

@ajlende ajlende merged commit 74cee79 into master Sep 24, 2020
@ajlende ajlende deleted the fix/10173-image_default_link_type-gallery branch September 24, 2020 15:55
@github-actions github-actions bot added this to the Gutenberg 9.1 milestone Sep 24, 2020
@nicolasbrouard
Copy link

Is this feature integrated in Wordpress 5.5.3?
Do I need to install the Gutenberg plugin?

@talldan
Copy link
Contributor

talldan commented Nov 10, 2020

@nicolasbrouard This won't be in WordPress 5.5.3, but it will be in the upcoming WordPress 5.6 due on 8th December (https://make.wordpress.org/core/5-6/).

@nicolasbrouard
Copy link

Awesome. Thanks a lot for the reply.

@cxlxin
Copy link

cxlxin commented Jan 27, 2022

Please review: As of WP 5.9 the image_default_link_type option doesn't work for the new galleries. Images do still work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

image_default_link_type is ignored by Gutenberg
5 participants