Remove duplicate key from tsconfig.base.json

[ediamin]

Description

This a very simple PR that removes the duplicate types key in root tsconfig.base.json file.

Current config contains ["react", "node", "requestidlecallback"], and [] as types property value.

{
	"compilerOptions": {
                 ...
		"target": "esnext",
		"types": ["react", "node", "requestidlecallback"],
                ...

		"typeRoots": [ "./typings", "./node_modules/@types" ],
		"types": []
	},
        ...
}

[ntsekouras]

Hey thanks for working on this. I'm concerned though and I feel that this in not correct, even though there is the duplication of types key.

I'm not an expert for TS and its config, but I believe this compilerOptions would be extracted somewhere and consumed. JS would then keep the last key declared, so now the types: [] overrides the above value.

So we should check to remove the duplicate value, but be sure what occurrence we have to keep.

Refs:
https://www.typescriptlang.org/tsconfig#typeRoots
https://www.typescriptlang.org/tsconfig#types

[ediamin]

Hey @ntsekouras, I'm new to TypeScript and was looking at the Gutenberg's configs today. Then I found the duplicate keys. But now I think I should remove the first key instead of the second key. I guess, since we're using the typeRoots here, we should leave the "types": [] as it is and remove the first one instead. Let's see what the experts say. Then I'll make the changes accordingly.

[sirreal]

Thanks for the PR!

… since we're using the typeRoots here, we should leave the "types": [] as it is and remove the first one instead.

This looks correct, can you make the change? I believe the first types is an oversight.

Happy to see you looking at types, I'll take the opportunity to plug #18838 in case you're looking for more opportunities to collaborate 😁

[ediamin]

@sirreal I've updated the code, please review now. And thanks, I'll definitely look at the #18838 👍

[ntsekouras]

Thanks for the help! 👍

[sirreal]

Thanks!

I'll reference this PR: #21581. It should have removed the types that we cleaned up here.