InnerBlocks: add select dependencies #25672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
Sep 28, 2020
| enableClickThrough: isNavigationMode() || isSmallScreen, | ||
| }; | ||
| } ); | ||
| const { hasOverlay, block, enableClickThrough } = useSelect( |
There was a problem hiding this comment.
We should avoid returning the whole block object, because the component only depends on a subset of the properties. I'll adjust in a separate commit if tests pass.
|
Size Change: -37 B (0%) Total Size: 1.18 MB
ℹ️ View Unchanged
|
ZebulanStanphill
added
the
[Feature] Nested / Inner Blocks
ntsekouras
reviewed
Sep 29, 2020
ellatrix
force-pushed
the
fix/inner-blocks-select-deps
branch
from
5c9fc38
to
2011bbb
Compare
ntsekouras
reviewed
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In addition, getBlockType and getBlockContext shouldn't be called on every render, but only when attributes change. useSelect acts as a memoizer.
How has this been tested?
Screenshots
Types of changes
Checklist: