Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Widgets Editor] Fix widget-area accessibility #25732

Merged
merged 3 commits into from Sep 30, 2020
Merged

[Widgets Editor] Fix widget-area accessibility #25732

merged 3 commits into from Sep 30, 2020

Conversation

kevin940726
Copy link
Member

Description

Fix #25675.

Remove the workaround introduced in #25645, by changing the <PanelBody> component to accept children as function and making use of the <DiscloureContent> component is reakit.

How has this been tested?

  1. Go to widgets screen
  2. Try toggling the widget areas
  3. Inspect the elements, and confirm that the panel body is not unmounted when collapsing.

Types of changes

New feature

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@kevin940726 kevin940726 added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Sep 30, 2020
@kevin940726 kevin940726 added this to PRs in progress in Block-based Widgets Editor via automation Sep 30, 2020
@github-actions
Copy link

Size Change: +2.54 kB (0%)

Total Size: 1.18 MB

Filename Size Change
build/block-directory/index.js 8.61 kB +1 B
build/block-editor/index.js 129 kB +62 B (0%)
build/block-library/index.js 135 kB -2 B (0%)
build/blocks/index.js 47.5 kB -2 B (0%)
build/components/index.js 169 kB +186 B (0%)
build/compose/index.js 9.42 kB -3 B (0%)
build/data/index.js 8.41 kB -3 B (0%)
build/edit-navigation/index.js 10.7 kB -1 B
build/edit-post/index.js 306 kB +1 B
build/edit-site/index.js 20.4 kB +4 B (0%)
build/edit-widgets/index.js 21.1 kB +2.37 kB (11%) ⚠️
build/edit-widgets/style-rtl.css 3 kB -33 B (1%)
build/edit-widgets/style.css 3 kB -32 B (1%)
build/editor/index.js 45.4 kB -1 B
build/format-library/index.js 7.49 kB -3 B (0%)
build/i18n/index.js 3.54 kB -2 B (0%)
build/shortcode/index.js 1.69 kB -1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.52 kB 0 B
build/api-fetch/index.js 3.35 kB 0 B
build/autop/index.js 2.72 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/style-rtl.css 11 kB 0 B
build/block-editor/style.css 11 kB 0 B
build/block-library/editor-rtl.css 8.6 kB 0 B
build/block-library/editor.css 8.6 kB 0 B
build/block-library/style-rtl.css 7.65 kB 0 B
build/block-library/style.css 7.64 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-default-parser/index.js 1.78 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/components/style-rtl.css 15.4 kB 0 B
build/components/style.css 15.4 kB 0 B
build/core-data/index.js 12 kB 0 B
build/data-controls/index.js 1.27 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 4.42 kB 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/edit-post/style-rtl.css 6.25 kB 0 B
build/edit-post/style.css 6.24 kB 0 B
build/edit-site/style-rtl.css 3.78 kB 0 B
build/edit-site/style.css 3.78 kB 0 B
build/editor/editor-styles-rtl.css 492 B 0 B
build/editor/editor-styles.css 493 B 0 B
build/editor/style-rtl.css 3.83 kB 0 B
build/editor/style.css 3.82 kB 0 B
build/element/index.js 4.44 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 1.74 kB 0 B
build/html-entities/index.js 621 B 0 B
build/is-shallow-equal/index.js 709 B 0 B
build/keyboard-shortcuts/index.js 2.39 kB 0 B
build/keycodes/index.js 1.85 kB 0 B
build/list-reusable-blocks/index.js 3.02 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.12 kB 0 B
build/notices/index.js 1.69 kB 0 B
build/nux/index.js 3.27 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.44 kB 0 B
build/primitives/index.js 1.34 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13 kB 0 B
build/server-side-render/index.js 2.6 kB 0 B
build/token-list/index.js 1.24 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.74 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

adamziel
adamziel approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@adamziel adamziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent - thank you!

@adamziel adamziel merged commit ba026ff into master Sep 30, 2020
Block-based Widgets Editor automation moved this from PRs in progress to Done Sep 30, 2020
@adamziel adamziel deleted the update/widget-area-toggle-a11y branch September 30, 2020 10:13
@github-actions github-actions bot added this to the Gutenberg 9.2 milestone Sep 30, 2020
kevin940726 added a commit that referenced this pull request Oct 6, 2020
@kevin940726
[Widgets Editor] Fix widget-area accessibility (#25732)
1aa0e08 
* Fix the state of the panel body and use function children

* Update README

* Add test for panel body
kevin940726 added a commit that referenced this pull request Oct 6, 2020
@kevin940726
[Widgets Editor] Fix widget-area accessibility (#25732)
2c573aa 
* Fix the state of the panel body and use function children

* Update README

* Add test for panel body
tellthemachines pushed a commit that referenced this pull request Oct 15, 2020
@kevin940726 @tellthemachines
[Widgets Editor] Fix widget-area accessibility (#25732)
2da48dd 
* Fix the state of the panel body and use function children

* Update README

* Add test for panel body
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamziel adamziel adamziel approved these changes

@draganescu draganescu Awaiting requested review from draganescu

@noisysocks noisysocks Awaiting requested review from noisysocks

@talldan talldan Awaiting requested review from talldan

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
No open projects
Block-based Widgets Editor
Done
Milestone
Gutenberg 9.2
Development

Successfully merging this pull request may close these issues.

Improve panel accessibility
2 participants
@kevin940726 @adamziel