External Link: Use CSS-in-JS #25751
Merged
External Link: Use CSS-in-JS #25751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
|
/cc @ItsJonQ |
youknowriad
reviewed
Oct 1, 2020
ItsJonQ
approved these changes
Oct 2, 2020
There was a problem hiding this comment.
🚀 from me! Thank you @saramarcondes ! Excited to see more components using the CSS-in-JS solutions :)
github-actions
bot
added
the
First-time Contributor
kevin940726
pushed a commit
that referenced
this pull request
Oct 6, 2020
* [@wordpress/components] Use CSS-in-JS for ExternalLink * Update snapshot tests
kevin940726
pushed a commit
that referenced
this pull request
Oct 6, 2020
* [@wordpress/components] Use CSS-in-JS for ExternalLink * Update snapshot tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
ExternalLinkcomponent to use CSS-in-JS similar to how newer components do like theAnglePickerControlandText. This also maintains the existing classname on theIconeven though it isn't being used by the component itself, it allows theIconto still be targeted by consumers, making this a non-breaking change.How has this been tested?
I've run storybook and observed that there are new visual differences in before and after.
Screenshots
Before:
After:
Types of changes
Checklist: