Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect attribute type specified in Search block #25813

Merged
merged 1 commit into from Oct 5, 2020
Merged

Fix incorrect attribute type specified in Search block #25813

merged 1 commit into from Oct 5, 2020

Conversation

bobbingwide
Copy link
Contributor

Avoid Notice: rest_validate_value_from_schema
Change the type for showLabel and buttonUseIcon from "bool" to "boolean" to avoid notices when WP_DEBUG is true.

Description

I've corrected the values to avoid Notices from rest_validate_value_from_schema

How has this been tested?

In a local development environment. After applying the change I edited and viewed the Search block I'd created earlier. The Notices were no longer displayed.

Screenshots

image

Types of changes

Typo fix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@bobbingwide
Fixes WordPress#25812 - Correct bool to boolean to avoid Notices
31401ee 
Avoid Notice: rest_validate_value_from_schema
@talldan talldan linked an issue Oct 5, 2020 that may be closed by this pull request
Definition of showLabel and buttonUseIcon in the search block's block.json should be "boolean" not "bool" #25812
Closed
@talldan talldan added [Block] Search Affects the Search Block - used to display a search field [Type] Bug An existing feature does not function as intended labels Oct 5, 2020
talldan
talldan approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bobbingwide. Appreciate the upstream fix to attribute validation as well.

@talldan talldan merged commit 654f7cb into WordPress:master Oct 5, 2020
@talldan talldan changed the title Fixes #25812 - Correct bool to boolean to avoid Notices Fix incorrect attribute type specified in Search block Oct 5, 2020
@github-actions github-actions bot added this to the Gutenberg 9.2 milestone Oct 5, 2020
kevin940726 pushed a commit that referenced this pull request Oct 6, 2020
@bobbingwide @kevin940726
Fixes #25812 - Correct bool to boolean to avoid Notices (#25813)
383fd35 
Avoid Notice: rest_validate_value_from_schema
kevin940726 pushed a commit that referenced this pull request Oct 6, 2020
@bobbingwide @kevin940726
Fixes #25812 - Correct bool to boolean to avoid Notices (#25813)
861fadf 
Avoid Notice: rest_validate_value_from_schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talldan talldan talldan approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@Soean Soean Awaiting requested review from Soean

Assignees
No one assigned
Labels
[Block] Search Affects the Search Block - used to display a search field [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 9.2
Development

Successfully merging this pull request may close these issues.

Definition of showLabel and buttonUseIcon in the search block's block.json should be "boolean" not "bool"
2 participants
@bobbingwide @talldan