Bring the block-based theme tutorial up to date #25830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
added
[Type] Enhancement
kjellr
requested review from
ajitbohra,
chrisvanpatten and
mkaz
as code owners
|
Size Change: 0 B Total Size: 1.18 MB ℹ️ View Unchanged
|
aristath
approved these changes
Oct 5, 2020
|
Looks good to me, there are some minor differences in the images compared to how the UI looks today, but nothing breaking and they are not related to the change to the theme.json file. |
carolinan
approved these changes
Oct 5, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the block-based themes tutorial up to date with Gutenberg v9.1 and the more recent theme.json spec. It also includes minor whitespace + formatting cleanup.
I'd appreciate another set of eyes on the
theme.jsonspec section, to make sure those updates are accurate.