Site editor: Mount both wp_template and wp_template_part EntityProviders to avoid remounting #25870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +22 B (0%) Total Size: 1.18 MB
ℹ️ View Unchanged
|
david-szabo97
changed the title
david-szabo97
changed the title
noahtallen
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
This tests well for me, I think we can merge it 🚀
My one thought is that it seems weird to have to wrap so many entity providers like this:
- entity provider (root/site)
- entity provider (wp_template)
- entity provider (wp_template_part)
- entity provider (global styles)
I wonder if there is a way we can abstract that further into one component - or maybe let entity provider handle multiple entities? Not sure. It feels like it could be cleaner.
But I don't think we need to figure that out right now :)
Definitely! A multi-entity provider would be great. We will need to discuss this with the core team. |
Copons
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #25743
Description
EntityProvideruses a different context provider component for each entity type. Which results in a remount since we are changing the component.Unfortunately,
EntityProvideris at the top of our tree, which results in a full Editor remount. Causing all the states to be lost. To avoid the remount, we introduce bothEntityProviderin the tree, rather than one dynamic component.How has this been tested?
yarn wp-env startTypes of changes
Bug fix
Checklist: