Prevent network requests related to ephemeral posts in the widgets editor #25899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Feature] Widgets Screen
adamziel
requested review from
draganescu,
mcsf,
mtias,
noisysocks and
talldan
adamziel
requested review from
kevin940726,
mmtr,
nerrad,
tellthemachines and
youknowriad
as code owners
|
Size Change: +10.4 kB (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
draganescu
reviewed
Oct 7, 2020
noisysocks
reviewed
Oct 8, 2020
packages/edit-widgets/src/components/edit-widgets-initializer/index.js
Outdated
Show resolved
Hide resolved
|
Yes I vote for @noisysocks idea and also call the option something that indicates that apiFetch won't request anything. Setting responseBody is weird :) |
It is still a hack indeed, multi-entity saving/editing would be the real answer here - let's explore it after 5.6 :-) |
draganescu
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR follows up the discussion from #25831:
The approach taken here is different. Instead of adding a new concept to
core-data, this PR simply plugs intoapi-fetchand prevents any unwanted requests from happening. While the implementation differs, the approach is inspired by Drupal's api-fetch.The advantage of this approach over the current approach is that it's resilient. It doesn't require any initialization, it doesn't rely on implementation details of the resolution pipeline (such as faking
startResolutionandendResolution), it won't be easily broken by updates tocore-data. The only hardcoded part is the path string, I'd rather not use the one specified indefaultEntities -> baseURLas the data structure there is just another implementation detail of the resolution system.The same treatment could be applied to the navigation editor which also uses an in-memory post as a convenience wrapper.
How has this been tested?
widget-arearelated network error logged.Types of changes
Non-breaking change
Checklist: