Widgets editor: Display Widget Area's name and description in the sidebar #25943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Enhancement
noisysocks
requested review from
adamziel,
draganescu,
kevin940726,
talldan,
tellthemachines and
youknowriad
as code owners
noisysocks
added
Needs Copy Review
|
@mapk: How's this look to you? |
|
Size Change: +2.48 kB (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
draganescu
reviewed
Oct 8, 2020
| let description; | ||
| if ( ! selectedWidgetArea ) { | ||
| description = __( | ||
| 'Widget Areas are global parts in your site’s layout that can accept blocks. These vary by theme, but are typically parts like your Sidebar or Footer.' |
There was a problem hiding this comment.
Is this text copied from somewhere?
There was a problem hiding this comment.
Yes this comes from the design in #25745 (comment).
| ); | ||
| } else if ( selectedWidgetAreaId === 'wp_inactive_widgets' ) { | ||
| description = __( | ||
| 'Blocks in this Widget Area will not be displayed in your site.' |
There was a problem hiding this comment.
The old use of inactive widgets was to "save" them for reuse, in order to not have to re-customize them by adding a new one. Perhaps we could explain this as well?
There was a problem hiding this comment.
I made this copy up on the fly 😅
@mapk: What should it say?
mapk
approved these changes
Oct 12, 2020
…tifier for backwards compatibility
kevin940726
reviewed
Oct 13, 2020
Comment on lines
15
to
19
| const selectedWidgetArea = | ||
| selectedWidgetAreaId && | ||
| widgetAreas?.find( | ||
| ( widgetArea ) => widgetArea.id === selectedWidgetAreaId | ||
| ); |
There was a problem hiding this comment.
Nitpick: Not sure about the performance impact, but maybe we would want to useMemo this so that we don't have to recalculate .find every time this component renders.
| <BlockIcon icon={ blockDefault } /> | ||
| <div> | ||
| <p>{ description }</p> | ||
| { widgetAreas?.length === 0 && ( |
There was a problem hiding this comment.
What if widgetAreas is nullish? Do we want to display the empty message in this case?
I think that depends on whether we treat this state as a loading state or an error state 🤔 ?
There was a problem hiding this comment.
If we display the empty message when widgetAreas is nullish (! widgetAreas || widgetAreas.length === 0) then we'll see a flash of the empty message when the page loads, which is quite jarring. It's more common that there are widget areas so I think best to be optimistic about that.
talldan
approved these changes
Oct 13, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25745.
Closes #24838.
Closes #25190.
This PR implements the mockup in #25745 (comment).
How to test