New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Editor: Navigation panel replace hardcoded menu strings with constants #26026
Merged
vindl
merged 2 commits into
master
from
update/navigation-panel-use-constants-for-menus
Oct 13, 2020
Merged
Site Editor: Navigation panel replace hardcoded menu strings with constants #26026
vindl
merged 2 commits into
master
from
update/navigation-panel-use-constants-for-menus
Oct 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -4 B (0%) Total Size: 1.19 MB
鈩癸笍 View Unchanged
|
vindl
approved these changes
Oct 12, 2020
ntsekouras
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always better to use constants in such use cases 馃憤
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace all hardcoded strings of
menuprops with constants. Easier to import a constant rather than remembering all those strings 馃槃How has this been tested?
Open Navigation panel and make sure you can navigate through all submenus
Types of changes
Code Quality
Checklist: