Fix/wrong classes search block

[MaggieCabrera]

Description

• Added missing width and height to the svg on the frontend
• Added has-icon class to the button when it's an icon isntead of text on the frontend (this was missing compared to the editor)
• Swapped the classes wp-block-search__icon-button and wp-block-search__text-button on the editor (they were correct on the frontend)

How has this been tested?

• Create search blocks that have icon button on the different positions it can have it.
• Create search blocks that have text button on the different positions too.
• Check the frontend, the icon shouldn't be huge.
• Check on the editor that when the block has an icon instead of text, the class wp-block-search__icon-button is applied. This doesn't have any visual impact, but it's needed for theming purposes.
• Check on the editor that when the block has an text instead of icon, the class wp-block-search__text-button is applied. This doesn't have any visual impact, but it's needed for theming purposes.

Screenshots

Before:

Editor:

Frontend:

After

Frontend:

Types of changes

Class changes and added width/height to svg that was missing. My changes bring the frontend result more in line with what the editor shows.

Fixes #25902

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR.

[kirilzh]

Thank you for this PR!

Looks good to me!

[github-actions]

Congratulations on your first merged pull request, @MaggieCabrera! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!