Try: Make class and style tests less brittle. #26079
Conversation
Instead of relying on the exact order of classnames and style attributes, split each string into an array and assert that they are equal sets which ignores differences due to order.
|
Similar may be needed in |
| explode( ' ', $expected_classes ), | ||
| explode( ' ', $class_list ) | ||
| ); | ||
| $this->assertEquals( |
There was a problem hiding this comment.
I presume this isn't assertEqualSets as foo:bar; foo:bart is not the same as foo:bart; foo:bar. Is that correct?
There was a problem hiding this comment.
It was actually unintentional 🤦 sorry about that.
But now that you say that, style property order could matter in some circumstances for things like browser fallbacks. So perhaps it should stay that way?
There was a problem hiding this comment.
@TimothyBJacobs Not just browser fallbacks. Although I'd consider it questionable practice, you can do something like padding: 4px; padding-left: 8px, where the left padding will be different depending on the property order.
It looks like |
|
Thanks for the review @peterwilsoncc! |
Instead of relying on the exact order of classnames and style attributes,
split each string into an array and assert that they are equal sets which
ignores differences due to order.
This hopefully will fix the test failures occurring on
master.