Add more CI status badges to README #26090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -4.33 kB (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
guarani
reviewed
Oct 14, 2020
There was a problem hiding this comment.
I previewed it here:
 |
|---|
I think it doesn't look overly crowded, although if some of the workflows had shorter names it could work better, e.g.:
| Before | After |
|---|---|
| Performance Tests | Perf Tests |
| End-to-End Tests | Web E2E Tests |
| Static Analysis (Linting, License, Type checks...) | Static Analysis |
| Unit Tests | Web Unit Tests |
| Create Block | Create Block (leave as is) |
| Storybook GitHub Pages | Storybook |
| React Native E2E Tests (iOS) | iOS E2E Tests |
| React Native E2E Tests (Android) | Android E2E Tests |
| Compressed Size | Compressed Size (leave as is) |
What do you think?
|
Thank you for opening a follow-up PR. How about we remove some of the less important badges to make sure it isn't so crowded? I think some of those jobs integrate with workflows in PRs before merging like Compressed Size or Performance Tests. @youknowriad should know better. |
|
True, the storybook deploy too, though to be honest, I don't care much about whether it's crowded or not :P |
|
Just removed some of the badges and seems to look better now. |
Looks good to me, @ceyhun! |
/badge.svg){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added all the GitHub Actions workflow badges to the README. Seems a bit crowded now, any ideas about the layout appreciated!