Fix icons type annotation

[sarayourfriend]

Description

From @sirreal:

'SVG' isn’t something we can get the props for in ComponentPropsWithoutRef<'SVG'> — It would have to be the SVG component type or just the SVGProps like in the diff

svg would work better (or should) but doesn't actually, for whatever reason. The following does work though (you can see that className for example will now show in the intellisense for Icon's props.

How has this been tested?

Tested using intellisense

Screenshots

Types of changes

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR.

[sirreal]

svg would work better (or should) but doesn't actually, for whatever reason. The following does work though (you can see that className for example will now show in the intellisense for Icon's props.

"svg" (quoted) works well:

/** @typedef {{icon: JSX.Element, size?: number} & import('react').ComponentPropsWithoutRef<'svg'>} IconProps */

However, it's the props for the raw HTML svg component. That's missing the isPressed?: boolean prop that's added to the SVG component wrapper. We can either get the props from the SVG component type:

/** @typedef {{icon: JSX.Element, size?: number} & import('react').ComponentPropsWithoutRef<import('@wordpress/primitives')['SVG']>} IconProps */

But they're already accessible directly from the primitives package like is done in this change:

/** @typedef {{icon: JSX.Element, size?: number} & import('@wordpress/primitives').SVGProps} IconProps */

[sirreal]

Thanks for the fix 👍