New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix editing Legacy Widgets doesn't enable "Save" button #26144
Merged
kevin940726
merged 1 commit into
master
from
update/fix-legacy-widget-not-triggering-updates
Oct 15, 2020
Merged
Fix editing Legacy Widgets doesn't enable "Save" button #26144
kevin940726
merged 1 commit into
master
from
update/fix-legacy-widget-not-triggering-updates
Oct 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +91 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Oct 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! This fixes the issue for me, and code looks tidy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Widgets Screen
The block-based screen that replaced widgets.php.
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #26084.
The original implementation only fires
onInstanceChangeon blur, which results in not enabling the "Save" button when editing Legacy Widgets. This PR changes it to use thechangeandinputevents, and use rAF to schedule the changes for performance optimization.We can make the rAF part a separate utility function to be used across different packages, but where should we put it?
How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist: