New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ToolbarButtons instead of Buttons in the Legacy Widget block's toolbar #26258
Merged
draganescu
merged 1 commit into
master
from
fix/use-toolbar-buttons-in-legacy-widget-toolbar
Oct 19, 2020
Merged
Use ToolbarButtons instead of Buttons in the Legacy Widget block's toolbar #26258
draganescu
merged 1 commit into
master
from
fix/use-toolbar-buttons-in-legacy-widget-toolbar
Oct 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +3 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this and works as described
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Legacy Widget
Affects the Legacy Widget Block - used for displaying Classic Widgets
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When testing the widget screen I noticed the block toolbar for the Legacy Widget Block doesn't use a Roving Tab Index. The toolbar instead has a tab stop for each button.
This is caused by the block using
Buttoncomponents instead ofToolbarButtoncomponents. This PR switches over the component. There's no visual change.How has this been tested?
masterthe last item is focused)masterthe preview button is focused)Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: