New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration: Rename default block handlers as reflecting name #2627

Merged
merged 1 commit into from Sep 1, 2017

Conversation

Projects
None yet
2 participants
@aduth
Member

aduth commented Aug 31, 2017

This pull request seeks to rename default block handler functions to better reflect that they operate on a block name, not a block instance, type, or otherwise. This brings default block API handlers in line with unknown type handlers, which were similarly renamed in bc4d6cd. I originally planned to include these changes in a related set of changes, but since it touched a handful of files, I felt it better to create a smaller, separate pull request.

Testing instructions:

Verify there is no regressions in the behavior of the default block (paragraph).

@aduth aduth added the Block API label Aug 31, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 31, 2017

Codecov Report

Merging #2627 into master will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2627   +/-   ##
=======================================
  Coverage   31.42%   31.42%           
=======================================
  Files         177      177           
  Lines        5407     5407           
  Branches      946      946           
=======================================
  Hits         1699     1699           
  Misses       3135     3135           
  Partials      573      573
Impacted Files Coverage Δ
blocks/api/registration.js 100% <ø> (ø) ⬆️
editor/modes/visual-editor/block-list.js 0% <0%> (ø) ⬆️
blocks/library/paragraph/index.js 33.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ab8ee...d618f4b. Read the comment docs.

codecov bot commented Aug 31, 2017

Codecov Report

Merging #2627 into master will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2627   +/-   ##
=======================================
  Coverage   31.42%   31.42%           
=======================================
  Files         177      177           
  Lines        5407     5407           
  Branches      946      946           
=======================================
  Hits         1699     1699           
  Misses       3135     3135           
  Partials      573      573
Impacted Files Coverage Δ
blocks/api/registration.js 100% <ø> (ø) ⬆️
editor/modes/visual-editor/block-list.js 0% <0%> (ø) ⬆️
blocks/library/paragraph/index.js 33.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ab8ee...d618f4b. Read the comment docs.

@mtias

This comment has been minimized.

Show comment
Hide comment
@mtias

mtias Aug 31, 2017

Contributor

Makes sense.

Contributor

mtias commented Aug 31, 2017

Makes sense.

@aduth aduth merged commit 6e663a4 into master Sep 1, 2017

3 checks passed

codecov/project 31.42% (+0%) compared to 02ab8ee
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@aduth aduth deleted the update/default-block-name branch Sep 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment