Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Color picker improvements, first round #2680
This PR tries to address a first round of improvements to the Color picker buttons.
@@ Coverage Diff @@ ## master #2680 +/- ## ========================================== - Coverage 33.77% 33.74% -0.03% ========================================== Files 191 191 Lines 5691 5695 +4 Branches 996 997 +1 ========================================== Hits 1922 1922 - Misses 3189 3192 +3 - Partials 580 581 +1
referenced this pull request
Sep 13, 2017
@aduth any specific reason for this rule:
seems a bit weird to me this actually can make any relevant difference:
Like rules on spacing within parentheses, it's merely a style convention aimed at encouraging consistency.
I would be glad to add these to the coding guidelines document but... the current atmosphere leads me to believe that it would be unwise to be codifying our React usage patterns at this point in time
(Will follow-up with a final review)