New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Block: Resizing an image sets the figure wrapper #2682

Merged
merged 1 commit into from Sep 7, 2017

Conversation

Projects
None yet
2 participants
@youknowriad
Contributor

youknowriad commented Sep 6, 2017

closes #2543

This PR apply the image resized width to its figure wrapper to constrain the caption in these boundaries.

Note: This PR makes previously resized image blocks invalid.

@youknowriad youknowriad self-assigned this Sep 6, 2017

@youknowriad youknowriad requested review from karmatosed and azaozz Sep 6, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 6, 2017

Codecov Report

Merging #2682 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2682      +/-   ##
==========================================
+ Coverage   33.03%   33.04%   +<.01%     
==========================================
  Files         182      182              
  Lines        5533     5535       +2     
  Branches      963      965       +2     
==========================================
+ Hits         1828     1829       +1     
  Misses       3137     3137              
- Partials      568      569       +1
Impacted Files Coverage Δ
blocks/library/image/block.js 0% <0%> (ø) ⬆️
blocks/library/image/index.js 64.7% <100%> (+2.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e1804...ffa079a. Read the comment docs.

codecov bot commented Sep 6, 2017

Codecov Report

Merging #2682 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2682      +/-   ##
==========================================
+ Coverage   33.03%   33.04%   +<.01%     
==========================================
  Files         182      182              
  Lines        5533     5535       +2     
  Branches      963      965       +2     
==========================================
+ Hits         1828     1829       +1     
  Misses       3137     3137              
- Partials      568      569       +1
Impacted Files Coverage Δ
blocks/library/image/block.js 0% <0%> (ø) ⬆️
blocks/library/image/index.js 64.7% <100%> (+2.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e1804...ffa079a. Read the comment docs.

@karmatosed

This fixes the issue, thanks!

@youknowriad youknowriad merged commit 1359fff into master Sep 7, 2017

3 checks passed

codecov/project 33.04% (+<.01%) compared to 92e1804
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@youknowriad youknowriad deleted the update/resize-image-wrapper branch Sep 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment