New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 'search' message to add context #2692

Merged
merged 3 commits into from Sep 25, 2017

Conversation

Projects
None yet
3 participants
@vladanost
Contributor

vladanost commented Sep 7, 2017

This PR is referencing issue #2338
I have updated the Inserter search message to read "Search blocks" to be identical to the screen reader text message above it.

@karmatosed

This comment has been minimized.

Show comment
Hide comment
@karmatosed

karmatosed Sep 24, 2017

Member

I still wonder how discoverable the word blocks is for people that don't know about blocks. In saying that 'Search blocks' is better than we currently have. I would be keen on more human language such as 'Find a block' or 'Search for a block' over 'Search blocks'. Could you iterate on that maybe?

Member

karmatosed commented Sep 24, 2017

I still wonder how discoverable the word blocks is for people that don't know about blocks. In saying that 'Search blocks' is better than we currently have. I would be keen on more human language such as 'Find a block' or 'Search for a block' over 'Search blocks'. Could you iterate on that maybe?

@vladanost

This comment has been minimized.

Show comment
Hide comment
@vladanost

vladanost Sep 25, 2017

Contributor

I went for 'Find a block'. It's shorter than 'Search for a block' and feels better to me than 'Search blocks'.

Contributor

vladanost commented Sep 25, 2017

I went for 'Find a block'. It's shorter than 'Search for a block' and feels better to me than 'Search blocks'.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 25, 2017

Codecov Report

Merging #2692 into master will increase coverage by 0.66%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2692      +/-   ##
==========================================
+ Coverage   33.16%   33.82%   +0.66%     
==========================================
  Files         182      189       +7     
  Lines        5530     5661     +131     
  Branches      963      988      +25     
==========================================
+ Hits         1834     1915      +81     
- Misses       3130     3171      +41     
- Partials      566      575       +9
Impacted Files Coverage Δ
editor/inserter/menu.js 49.59% <ø> (+1.18%) ⬆️
components/popover/index.js 88.04% <0%> (-4.92%) ⬇️
editor/selectors.js 94.73% <0%> (-1.67%) ⬇️
editor/sidebar/post-visibility/index.js 45.23% <0%> (-0.92%) ⬇️
blocks/api/parser.js 98.14% <0%> (-0.04%) ⬇️
components/form-file-upload/index.js 71.42% <0%> (ø) ⬆️
components/popover/detect-outside.js 25% <0%> (ø) ⬆️
editor/modes/visual-editor/block-list.js 0% <0%> (ø) ⬆️
editor/modes/visual-editor/block-crash-boundary.js 0% <0%> (ø) ⬆️
editor/writing-flow/index.js 0% <0%> (ø) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1359fff...036ba8c. Read the comment docs.

codecov bot commented Sep 25, 2017

Codecov Report

Merging #2692 into master will increase coverage by 0.66%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2692      +/-   ##
==========================================
+ Coverage   33.16%   33.82%   +0.66%     
==========================================
  Files         182      189       +7     
  Lines        5530     5661     +131     
  Branches      963      988      +25     
==========================================
+ Hits         1834     1915      +81     
- Misses       3130     3171      +41     
- Partials      566      575       +9
Impacted Files Coverage Δ
editor/inserter/menu.js 49.59% <ø> (+1.18%) ⬆️
components/popover/index.js 88.04% <0%> (-4.92%) ⬇️
editor/selectors.js 94.73% <0%> (-1.67%) ⬇️
editor/sidebar/post-visibility/index.js 45.23% <0%> (-0.92%) ⬇️
blocks/api/parser.js 98.14% <0%> (-0.04%) ⬇️
components/form-file-upload/index.js 71.42% <0%> (ø) ⬆️
components/popover/detect-outside.js 25% <0%> (ø) ⬆️
editor/modes/visual-editor/block-list.js 0% <0%> (ø) ⬆️
editor/modes/visual-editor/block-crash-boundary.js 0% <0%> (ø) ⬆️
editor/writing-flow/index.js 0% <0%> (ø) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1359fff...036ba8c. Read the comment docs.

@karmatosed

This comment has been minimized.

Show comment
Hide comment
@karmatosed

karmatosed Sep 25, 2017

Member

I think keeping it as Search is better for translation, find doesn't have the same context.

Member

karmatosed commented Sep 25, 2017

I think keeping it as Search is better for translation, find doesn't have the same context.

vagrant

@karmatosed karmatosed merged commit fb049ba into WordPress:master Sep 25, 2017

2 checks passed

codecov/project 33.82% (+0.66%) compared to 1359fff
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vladanost vladanost deleted the vladanost:update/inserter-search-message branch Sep 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment