New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes position of upload svg on mobile #2693

Merged
merged 2 commits into from Sep 22, 2017

Conversation

Projects
None yet
4 participants
@karmatosed
Member

karmatosed commented Sep 7, 2017

This works for any 'not large' device.

Fixes #2671

This was before on an iPhone 7 Plus

img_1441 png

After

Mobile:

screen shot 2017-09-22 at 09 04 26

Desktop:

screen shot 2017-09-22 at 09 09 39

Tammie Lister
Fixes position of svg on mobile
This works for any 'not large' device.

@karmatosed karmatosed requested a review from mtias Sep 7, 2017

@karmatosed karmatosed changed the title from Fixes position of svg on mobile to Fixes position of upload svg on mobile Sep 7, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 7, 2017

Codecov Report

Merging #2693 into master will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2693      +/-   ##
==========================================
+ Coverage   33.69%   33.93%   +0.24%     
==========================================
  Files         185      185              
  Lines        5594     5743     +149     
  Branches      976     1020      +44     
==========================================
+ Hits         1885     1949      +64     
- Misses       3141     3203      +62     
- Partials      568      591      +23
Impacted Files Coverage Δ
components/form-file-upload/index.js 71.42% <ø> (ø) ⬆️
editor/header/index.js 0% <0%> (ø) ⬆️
editor/writing-flow/index.js 0% <0%> (ø) ⬆️
editor/modes/visual-editor/block.js 0% <0%> (ø) ⬆️
blocks/library/image/block.js 0% <0%> (ø) ⬆️
blocks/api/registration.js 100% <0%> (ø) ⬆️
editor/modes/text-editor/index.js 0% <0%> (ø) ⬆️
editor/sidebar/index.js 0% <0%> (ø) ⬆️
editor/modes/visual-editor/block-crash-boundary.js 0% <0%> (ø) ⬆️
...ebar/post-taxonomies/hierarchical-term-selector.js 0% <0%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a93c553...b2d861b. Read the comment docs.

codecov bot commented Sep 7, 2017

Codecov Report

Merging #2693 into master will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2693      +/-   ##
==========================================
+ Coverage   33.69%   33.93%   +0.24%     
==========================================
  Files         185      185              
  Lines        5594     5743     +149     
  Branches      976     1020      +44     
==========================================
+ Hits         1885     1949      +64     
- Misses       3141     3203      +62     
- Partials      568      591      +23
Impacted Files Coverage Δ
components/form-file-upload/index.js 71.42% <ø> (ø) ⬆️
editor/header/index.js 0% <0%> (ø) ⬆️
editor/writing-flow/index.js 0% <0%> (ø) ⬆️
editor/modes/visual-editor/block.js 0% <0%> (ø) ⬆️
blocks/library/image/block.js 0% <0%> (ø) ⬆️
blocks/api/registration.js 100% <0%> (ø) ⬆️
editor/modes/text-editor/index.js 0% <0%> (ø) ⬆️
editor/sidebar/index.js 0% <0%> (ø) ⬆️
editor/modes/visual-editor/block-crash-boundary.js 0% <0%> (ø) ⬆️
...ebar/post-taxonomies/hierarchical-term-selector.js 0% <0%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a93c553...b2d861b. Read the comment docs.

@aduth

Is #1745 the right issue to be closing? I'm not sure what to be testing here.

Show outdated Hide outdated editor/header/tools/style.scss Outdated
@gziolo

This comment has been minimized.

Show comment
Hide comment
@gziolo

gziolo Sep 21, 2017

Member

@karmatosed, it looks like wrong issue is referenced here. Can you provide some testing instructions here?

Member

gziolo commented Sep 21, 2017

@karmatosed, it looks like wrong issue is referenced here. Can you provide some testing instructions here?

Show outdated Hide outdated editor/header/tools/style.scss Outdated
@karmatosed

This comment has been minimized.

Show comment
Hide comment
@karmatosed

karmatosed Sep 21, 2017

Member

I have updated with the issue it should have referenced, my apologies it was relating to a different issue. #2671

Member

karmatosed commented Sep 21, 2017

I have updated with the issue it should have referenced, my apologies it was relating to a different issue. #2671

@gziolo gziolo self-assigned this Sep 22, 2017

@gziolo

This comment has been minimized.

Show comment
Hide comment
@gziolo

gziolo Sep 22, 2017

Member

@mtias can you validate my style changes? Just saying, I'm not an expert in this field :)

Member

gziolo commented Sep 22, 2017

@mtias can you validate my style changes? Just saying, I'm not an expert in this field :)

@mtias

This comment has been minimized.

Show comment
Hide comment
@mtias

mtias Sep 22, 2017

Contributor

@gziolo seems good, though you might also have to do for galleries (that's why I was hoping it could be done for https://github.com/WordPress/gutenberg/tree/master/blocks/media-upload-button directly).

Contributor

mtias commented Sep 22, 2017

@gziolo seems good, though you might also have to do for galleries (that's why I was hoping it could be done for https://github.com/WordPress/gutenberg/tree/master/blocks/media-upload-button directly).

@gziolo

This comment has been minimized.

Show comment
Hide comment
@gziolo

gziolo Sep 22, 2017

Member

It makes sense, I will update 👍

Member

gziolo commented Sep 22, 2017

It makes sense, I will update 👍

@gziolo

This comment has been minimized.

Show comment
Hide comment
@gziolo

gziolo Sep 22, 2017

Member

It's a different component <FormFileUpload /> :) Anyways updated and it syncs nicely between those two mentioned blocks:

screen shot 2017-09-22 at 13 02 13

Member

gziolo commented Sep 22, 2017

It's a different component <FormFileUpload /> :) Anyways updated and it syncs nicely between those two mentioned blocks:

screen shot 2017-09-22 at 13 02 13

@mtias

This comment has been minimized.

Show comment
Hide comment
@mtias

mtias Sep 22, 2017

Contributor

🚢 it

Contributor

mtias commented Sep 22, 2017

🚢 it

@gziolo gziolo merged commit 26369c3 into master Sep 22, 2017

3 checks passed

codecov/project 33.93% (+0.24%) compared to a93c553
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@gziolo gziolo deleted the try/mobile-upload-svg-position branch Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment