Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Components: Close popover by escape keypress #2697
This pull request seeks to enhance the Popover component to handle escape keypress and focus return for closing the focused dialog. This also helps consolidate existing but inconsistently-applied approaches for this behavior.
Verify that a focused popover can be closed by clicking outside or pressing escape. When pressing escape, observe that focus returns to the element which had been focused prior to opening the dialog.
(Repeat for Visibility, Schedule popovers)
When tabbing through to the end of a popover's tabbable elements, we should do one or the other of:
@@ Coverage Diff @@ ## master #2697 +/- ## ========================================== + Coverage 33.64% 33.67% +0.02% ========================================== Files 185 185 Lines 5584 5591 +7 Branches 973 975 +2 ========================================== + Hits 1879 1883 +4 - Misses 3138 3139 +1 - Partials 567 569 +2