[e2e tests]: Fix assertions number check #27802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
the
[Type] Automated Testing
ntsekouras
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
ntsekouras
force-pushed
the
try/fix-e2e-multi-entities-save-temp
branch
from
3198e24
to
c9d7dc3
Compare
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
ntsekouras
changed the title
This was referenced Dec 18, 2020
|
Thanks for fixing the failing tests. Honestly, I think we should consider removing the When I wrote this originally I thought I counted 26 and the test kept failing saying there were 27 (i figured the computer was better at counting than I was). Now its failing and saying 26? It seems a bit fragile and there isn't much of a purpose for having it. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Temp fix for e2e tests to pass. Needs more checking about the reason it actually happened..