New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow toolbar wrapper to be clicked through #2784

Merged
merged 1 commit into from Sep 25, 2017

Conversation

Projects
None yet
2 participants
@iseulde
Member

iseulde commented Sep 25, 2017

Description

When you click right next to a toolbar horizontally (e.g. the end of a line of a paragraph), the wrapper of the toolbar will block it, so nothing happens. This PR fixes this by allowing you to click through the wrapper. Not sure if it's a good fix, maybe it can be addressed by removing the wrapper or not let it take up full width, but I'm not sure how that might affect the rest.

@iseulde iseulde added the [Type] Bug label Sep 25, 2017

@iseulde iseulde requested a review from jasmussen Sep 25, 2017

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Sep 25, 2017

Contributor

Impressive! Works great for me, and nice little fix! 👍 👍

Contributor

jasmussen commented Sep 25, 2017

Impressive! Works great for me, and nice little fix! 👍 👍

@iseulde iseulde merged commit 7b25dff into master Sep 25, 2017

3 checks passed

codecov/project 33.42% remains the same compared to 98f3a87
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@iseulde iseulde deleted the fix/click-through-toolbar-wrapper branch Sep 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment