New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove touch listeners from multi select #2785

Merged
merged 1 commit into from Sep 28, 2017

Conversation

Projects
None yet
1 participant
@iseulde
Member

iseulde commented Sep 25, 2017

Description

This PR removes touch listeners to handle multi select. They will not do anything as touchmove scrolls, where mousemove does not. We'll have to find another way to do multi select on touch devices.

@iseulde iseulde added the [Type] Bug label Sep 25, 2017

@iseulde iseulde changed the title from Remove touch listeners from multi select as they won't do anything to Remove touch listeners from multi select Sep 25, 2017

@iseulde

This comment has been minimized.

Show comment
Hide comment
@iseulde

iseulde Sep 28, 2017

Member

Going ahead with this as it's a small straightforward change that only removes something that doesn't do anything. :)

Member

iseulde commented Sep 28, 2017

Going ahead with this as it's a small straightforward change that only removes something that doesn't do anything. :)

@iseulde iseulde merged commit 35254af into master Sep 28, 2017

3 checks passed

codecov/project 33.46% (+0.03%) compared to 98f3a87
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@iseulde iseulde deleted the remove/touch-multi-select branch Sep 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment