Add block transforms preview #27861
Merged
Add block transforms preview #27861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
the
[Feature] Block Conversion
ntsekouras
requested review from
mcsf,
youknowriad,
mtias,
gziolo and
jasmussen
|
Size Change: +34 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Dec 23, 2020
| return ( | ||
| <MenuGroup | ||
| label={ __( 'Styles' ) } | ||
| className="block-editor-block-switcher__styles__menugroup" | ||
| > | ||
| { hoveredClassName && ( | ||
| <PreviewBlockPopover | ||
| hoveredBlock={ hoveredBlock } | ||
| hoveredClassName={ hoveredClassName } | ||
| blocks={ |
There was a problem hiding this comment.
Block styles can be applied only when a single block is selected. It's only changing the CSS class name applied so it feels like blockType.example shouldn't be needed here. However, it looks like some sort of design decision from the past. Maybe to account for the case when a block has not enough or too much content 🤷🏻♂️
There was a problem hiding this comment.
Yeah, I didn't look into it deeper for now, but it looks like it's been like this for the reason you mentioned (existing content..)
|
The preview for styles feels a little bit like a duplication but I believe it existed before:
Did it always work only when hovering an item? In the inserter, it shows the preview also when navigating with the keyboard. For block transforms it looks great, both for a single block and multiple selected blocks 👏🏻 |
Yes. I actually checked it myself when implementing because it made sense to show the preview with keyboard navigation. Maybe in a follow up? What do you think? |
|
Sure, a follow-up to align behavior is a great idea. I wasn't sure how it works in the main branch. |
gziolo
approved these changes
Dec 23, 2020
|
Thanks for the gif. From a quick glance at it, it seems like a cool feature! Except perhaps for the style variation transform, those are already thumbnails, it feels a little duplicate. It's fine probably? And maybe we can revisit? |
|
Same it makes me wonder whether we should just show a simple list for the style variations too. |
This had been also discussed in my first GB PR: #23028. styles design issue: #27870 |
|
This is great — nice that it works with multi-transforms as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves: #26399
This PR adds previews to block transforms.