Site Editor: Hide resize handle. #28272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
|
Size Change: -9 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Jan 18, 2021
| margin-top: $default-block-margin; | ||
| margin-bottom: $default-block-margin; | ||
|
|
||
| // This needs high specificity as it's output as an inline style by the library. |
There was a problem hiding this comment.
which library can override this?
There was a problem hiding this comment.
I also wonder why we had the issue only in the site editor? Is it about the iframe? Does it mean we have another similar style elsewhere that we could remove now?
There was a problem hiding this comment.
I assume it's caused by TextareaAutosize which is used in context of the component. resize: horizontal; gets output as an inline style.
There was a problem hiding this comment.
Do you know why it doesn't happen in the post editor?
There was a problem hiding this comment.
I don't know why, for whatever reason the resize style does not appear to get output there. Here's some example markup:
<textarea role="button" aria-label="Add block" class="block-editor-default-block-appender__content" readonly="" rows="1" style="overflow: hidden; overflow-wrap: break-word; height: 25px;">Start writing or type / to choose a block</textarea>
There was a problem hiding this comment.
weird. Maybe the library detects an iframe or something and add it. Weird though.
youknowriad
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a small resize handle in the default block editor appender:
This resize handle is added as an inline style, presumably by the React AutoSize library:
An
!importantwas the only way to hide it: